BUG: add minor version to MacOS 11 and 12 tags as workaround #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
This code LTGM and works with SciPy and conda-forge Python, thanks @FFY00. I just suggested a change to one comment for clarity/correctness, because it's not what macOS does. My Python version for example:
>>> import sysconfig
>>> platform_ = sysconfig.get_platform()
>>> parts = platform_.split("-")
>>> parts
['macosx', '11.0', 'arm64']
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
mac-minor-version-workaround
branch
from
eff5353
to
1d22f6a
Compare
|
Right, I have changed the comment accordingly. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filipe Laíns lains@riseup.net