BUG: fix all RPATHs that start with $ORIGIN #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Thanks. This looks good. Just one comment.
Well, two actually. The commit message should be something like: BUG: fix all RPATHs that start with $ORIGIN or something similar, where the BUG: prefix is the important change. It would also be great to explain the motivation for the change in the commit message (something similar to the description of the issue). And it should contain Fixes: #509. as last line.
|
This fixes only the the RPATH handling for ELF binaries on Linux. The macOS code needs a similar change. |
metab0t
force-pushed
the
rpath_fix
branch
2 times, most recently
from
bf2f0f7
to
98d3544
Compare
metab0t
changed the title
dnicolodi
reviewed
Oct 4, 2023
dnicolodi
reviewed
Oct 4, 2023
When shared libraries are build in a project subdir or in a subproject, the RAPTH added by meson pointing to the shared library build directory is not just '$ORIGIN/' but a longer relative path. Apply the same fix to all RPATHs that start with '$ORING/'. Fixes mesonbuild#509.
|
I've pushed a patch that fixes the identified issues. Please take a look. |
Thanks for the fix! LGTM |
metab0t
added a commit
to metab0t/HiGHS
that referenced
this pull request
Oct 5, 2023
meson-python 0.14.0 has a bug that handles rpath of python binding incorrectly. Use 0.13.2 temporarily as a fix. The upstream fix has landed in mesonbuild/meson-python#510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #509