MAINT: improve support for free-threaded CPython #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
the
maintenance
|
Looks like a typo fix in gh-613 has a draft fix already, but with more changes. Do you want to finish that PR, or should we fix this typo failure separately first? |
rgommers
force-pushed
the
support-nogil
branch
2 times, most recently
from
64bbf42
to
ef51f8a
Compare
This should be fixed in main already. I think you just need to rebase on current main. |
dnicolodi
reviewed
Apr 23, 2024
The free-threaded CPython build does not support the limited API yet, and won't in the near future. To avoid either cryptic build failures or a successfull build yielding an `abi3` tag which would not be correct, raise a clear error and don't attempt to build.
Support for free-threaded CPython in Cython is still a work in progress, see e.g. cython#6137 - this will land in Cython 3.1.0, and the skipped test does pass when using Cython built from the branch in cython#6137.
dnicolodi
force-pushed
the
support-nogil
branch
from
90d633e
to
800eca7
Compare
dnicolodi
approved these changes
Apr 23, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in pypa/packaging#727, free-threaded CPython does not support the limited API. Hence raise an exception if a
limited-apibuild is requested.Also skip/update a few tests that were failing when run under a free-threaded interpreter.
Note that we are already producing the correct wheel tags, since that comes from
sysconfig.get_config_var('EXT_SUFFIX').Addresses part of gh-499. There will be more to do - most importantly adding a CI job. This probably only makes sense to do once the
setup-pythonaction adds support (xref actions/setup-python#771). This may happen around the CPython 3.13 beta 1 release (May 7th).I'll add notes on how to test with a free-threaded build on gh-499 (it's not completely trivial yet).