Skip to content

Commit

Permalink
i18n: Add data_dirs kwarg to merge_file()
Browse files Browse the repository at this point in the history
For parity with gettext()

Fixes #1565
  • Loading branch information
TingPing committed Apr 8, 2017
1 parent c80ca38 commit 058b300
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 2 deletions.
3 changes: 3 additions & 0 deletions mesonbuild/mesonmain.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@ def run_script_command(args):
elif cmdname == 'gtkdoc':
import mesonbuild.scripts.gtkdochelper as abc
cmdfunc = abc.run
elif cmdname == 'msgfmthelper':
import mesonbuild.scripts.msgfmthelper as abc
cmdfunc = abc.run
elif cmdname == 'regencheck':
import mesonbuild.scripts.regen_checker as abc
cmdfunc = abc.run
Expand Down
11 changes: 9 additions & 2 deletions mesonbuild/modules/i18n.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,15 @@ def merge_file(self, state, args, kwargs):
if file_type not in VALID_TYPES:
raise MesonException('i18n: "{}" is not a valid type {}'.format(file_type, VALID_TYPES))

kwargs['command'] = ['msgfmt', '--' + file_type,
'--template', '@INPUT@', '-d', podir, '-o', '@OUTPUT@']
datadirs = mesonlib.stringlistify(kwargs.pop('data_dirs', []))
datadirs = '--datadirs=' + ':'.join(datadirs) if datadirs else None

command = [state.environment.get_build_command(), '--internal', 'msgfmthelper',
'@INPUT@', '@OUTPUT@', file_type, podir]
if datadirs:
command.append(datadirs)

kwargs['command'] = command
ct = build.CustomTarget(kwargs['output'] + '_merge', state.subdir, kwargs)
return ModuleReturnValue(ct, [ct])

Expand Down
31 changes: 31 additions & 0 deletions mesonbuild/scripts/msgfmthelper.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Copyright 2016 The Meson development team

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at

# http://www.apache.org/licenses/LICENSE-2.0

# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import argparse
import subprocess

parser = argparse.ArgumentParser()
parser.add_argument('input')
parser.add_argument('output')
parser.add_argument('type')
parser.add_argument('podir')
parser.add_argument('--datadirs', default='')


def run(args):
options = parser.parse_args(args)
env = {'GETTEXTDATADIRS': options.datadirs} if options.datadirs else None
return subprocess.call(['msgfmt', '--' + options.type, '-d', options.podir,
'--template', options.input, '-o', options.output],
env=env)

0 comments on commit 058b300

Please sign in to comment.