Skip to content

Commit

Permalink
vs2010backend: fix incompatibility with custom manifests
Browse files Browse the repository at this point in the history
EmbedManifest seems to default to true, which creates a default manifest based on other parameters (likewise defaults) and makes it impossible to supply your own with CREATEPROCESS_MANIFEST_RESOURCE_ID. There is value to being able to do this and no value to the default one, so this should be disabled.
  • Loading branch information
LBPHacker committed Nov 4, 2023
1 parent 74712f2 commit 56cb3ef
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions mesonbuild/backend/vs2010backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,8 @@ def create_basic_project(self, target_name, *,
if target_ext:
ET.SubElement(direlem, 'TargetExt').text = target_ext

ET.SubElement(direlem, 'EmbedManifest').text = 'false'

return (root, type_config)

def gen_run_target_vcxproj(self, target: build.RunTarget, ofname: str, guid: str) -> None:
Expand Down

0 comments on commit 56cb3ef

Please sign in to comment.