Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'clean' target fails when custom_target's output is a directory #1220

Closed
fatih-asici opened this issue Dec 19, 2016 · 1 comment
Closed

'clean' target fails when custom_target's output is a directory #1220

fatih-asici opened this issue Dec 19, 2016 · 1 comment
Milestone
0.37.1

Comments

@fatih-asici
Copy link

I can reproduce it with this test case: test cases/common/131 custom target directory install

It gives the following error:

[1/1] 'Cleaning'
FAILED: clean 
'ninja' '-t' 'clean'
ninja: error: remove(html): Directory not empty
Cleaning... 0 files.
ninja: build stopped: subcommand failed.
@nirbheek
Copy link
Member

This is a Ninja thing apparently; on Linux it only removes empty directories on clean (ninja-build/ninja#828). We will have to add our own tool that maintains a list of directories and deletes them.

We should also enable cleaning in the CI so we don't break this again.

@nirbheek nirbheek added this to the 0.37.1 milestone Dec 19, 2016
@nirbheek nirbheek mentioned this issue Dec 19, 2016
Merged
geier1993 pushed a commit to geier1993/meson that referenced this issue Dec 29, 2016
@nirbheek @geier1993
run_project_tests.py: Also do ninja clean on tests
3a6e171 
This will catch things like mesonbuild#1220
geier1993 pushed a commit to geier1993/meson that referenced this issue Dec 29, 2016
@nirbheek @geier1993
Use a script to clean-up custom-target output dirs
c3c9360 
The script will manually delete all custom_target outputs that are
directories instead of files. This is needed because on platforms other
than Windows, Ninja only deletes directories while cleaning if they are
empty.

Closes mesonbuild#1220
@MatthewScholefield MatthewScholefield mentioned this issue Apr 22, 2017
Closed
@annacrombie annacrombie mentioned this issue Apr 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.37.1
Development

No branches or pull requests
2 participants
@nirbheek @fatih-asici