/meson

find_library flags for the C language lands in valac command line #1939

Closed
arteymix opened this Issue Jun 13, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
dependencies regression vala
Projects
None yet
Milestone
No milestone
3 participants
@arteymix @ricotz @nirbheek
@arteymix
Contributor

arteymix commented Jun 13, 2017

Here's a example of passing C flags to a Vala target:

https://github.com/valum-framework/valum/blob/master/src/vsgi/servers/meson.build#L11

The result (note the -lfcgi flag that valac does not understand):

[1/99] Compiling Vala source ../src/vsgi/servers/vsgi-fastcgi.vala src/vsgi/vsgi-0.4.vapi.
FAILED: src/vsgi/servers/vsgi-fastcgi@sha/vsgi-fastcgi.c src/vsgi/servers/vsgi-fastcgi.h src/vsgi/servers/vsgi-fastcgi.vapi 
valac -C --debug --enable-experimental --enable-deprecated --vapidir=/home/guillaume/Projets/valum/vapi --define=GLIB_2_50 --define=GIO_2_44 --define=SOUP_2_48 --define=LIBSYSTEMD --define=HAVE_MEMMEM /home/guillaume/Projets/valum/src/vsgi/servers/vsgi-fastcgi-internal.vapi /home/guillaume/Projets/valum/src/vsgi/servers/fcgi.vapi -lfcgi --pkg libsoup-2.4 --pkg gio-unix-2.0 --pkg gio-2.0 --pkg gobject-2.0 --target-glib 2.40 --pkg glib-2.0 -d src/vsgi/servers/vsgi-fastcgi@sha --library=vsgi-fastcgi -H src/vsgi/servers/vsgi-fastcgi.h --use-header --vapi ../vsgi-fastcgi.vapi ../src/vsgi/servers/vsgi-fastcgi.vala src/vsgi/vsgi-0.4.vapi
Option inconnue -lfcgi
Run 'valac --help' to see a full list of available command line options.
[6/99] Compiling C object 'src/valum/valum-0.4@sha/src_valum_valum-0.4@sha_valum-sequence.c.o'.
ninja: build stopped: subcommand failed.

@nirbheek nirbheek added dependencies regression vala labels Jun 13, 2017

@nirbheek nirbheek added this to the 0.41.1 milestone Jun 13, 2017

nirbheek added a commit to centricular/meson that referenced this issue Jun 13, 2017

@nirbheek
tests: Add a test for C library in Vala target 
mesonbuild#1939
0ff6b7a

nirbheek added a commit to centricular/meson that referenced this issue Jun 13, 2017

@nirbheek
Make external library no-op when used with incompatible target 
This is how it used to behave earlier, but we accidentally regressed

Closes mesonbuild#1939
376a054

This was referenced Jun 13, 2017

Merged
Closed
@ricotz
Contributor

ricotz commented Jun 15, 2017

It seems this issue happens the other way around too. So vala_args like [ '-D', 'HAVE_FOO' ] end up in c_args.

@eyelash eyelash referenced this issue in eyelash/xi-gtk Jun 16, 2017

Closed

Error building under Arch Linux #29

@jpakkane jpakkane closed this in #1941 Jun 17, 2017

jpakkane added a commit that referenced this issue Jun 17, 2017

@nirbheek @jpakkane
Make external library no-op when used with incompatible target (#1941) 
* tests: Add a test for C library in Vala target

#1939

* Make external library no-op when used with incompatible target

This is how it used to behave earlier, but we accidentally regressed

Closes #1939

All checks have passed

2 successful checks
continuous-integration/appveyor/branch — AppVeyor build succeeded
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
73c0678

@arteymix arteymix referenced this issue in valum-framework/valum Jun 18, 2017

Closed

fcgi meson error #212

@nirbheek nirbheek modified the milestone: 0.41.1 Jun 20, 2017

glslang added a commit to glslang/meson that referenced this issue Jun 25, 2017

@nirbheek @glslang
Make external library no-op when used with incompatible target (#1941) 
* tests: Add a test for C library in Vala target

mesonbuild#1939

* Make external library no-op when used with incompatible target

This is how it used to behave earlier, but we accidentally regressed

Closes mesonbuild#1939
This commit was signed with a verified signature.
@glslang glslang
GPG key ID: 51893645F4723BC9 Learn about signing commits
53d6048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment