Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler object methods don't warn about unknown kwargs #2364

Open
ystreet opened this issue Sep 22, 2017 · 4 comments
Open

compiler object methods don't warn about unknown kwargs #2364

ystreet opened this issue Sep 22, 2017 · 4 comments

Comments

@ystreet
Copy link
Contributor

ystreet commented Sep 22, 2017

As mentioned on the tin.

https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/meson.build?id=980ddfdfb740107ce8d9db3f8679d235af757412#n366

Which results in:

Command line:  ccache cc /tmp/tmp3s718w9b/testfile.c -O0 -pipe -D_FILE_OFFSET_BITS=64 -c -o /tmp/tmp3s718w9b/output.obj 

Code:
 void f (void) {}
Compiler stdout:
 
Compiler stderr:

We either need to add support for the prefix kwarg or error out on its use in cc.compiles().

GStreamer bug: https://bugzilla.gnome.org/show_bug.cgi?id=787964

@nirbheek
Copy link
Member

Hmm, looks like we don't use the @permittedKwargs decorator for compiler methods.

@nirbheek nirbheek changed the title cc.compiles() prefix kwarg is silently ignored compiler object methods don't warn about unknown kwargs Sep 22, 2017
@tp-m tp-m added the gstreamer label Dec 28, 2017
@tp-m
Copy link
Member

tp-m commented Dec 28, 2017

Is there a consensus on whether cc.compiles() should support prefix: or not?

@nirbheek
Copy link
Member

No, but I guess we should add it just for consistency? It would make the reference manual simpler too.

@tp-m
Copy link
Member

tp-m commented Apr 20, 2018

We should decide if we want a prefix: kwarg for cc.compiles() or not.

If not, we can close this bug, because we do get warnings now. If yes, we should retitle.

flowergom pushed a commit to webosose/gstreamer that referenced this issue Jun 14, 2019
cc.compiles() doesn't have a 'prefix' argument (yet) and the
prefix has already been prepended to the source code snippets.

mesonbuild/meson#2364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants