New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing a dummy dependency to library() doesn't work #2872
Comments
Would a simple "declare_dependency()" have the same effect? (maybe the docs should recommend that instead if that's the case) |
@jon-turney I believe your patch from #2615 caused this regression. |
ah, the object returned by declare_dependency() returns true for found(), so that's not a viable replacement. |
Make not-found dependency object identically to prior to PR mesonbuild#2615 Extend test case to cover uses of the not-found dependency object Fixes mesonbuild#2872 Also, prevent direct instantation of class Dependency, since BuildTarget.add_deps() rejects that. It might be better to fix BuildTarget.add_deps() and look for any other similar problems...
Make not-found dependency object identically to prior to PR mesonbuild#2615 Extend test case to cover uses of the not-found dependency object Fixes mesonbuild#2872 Also, prevent direct instantiation of class Dependency, since BuildTarget.add_deps() rejects that. It might be better to fix BuildTarget.add_deps() and look for any other similar problems...
Bother, that's a bit disappointing. Not sure of the best way to fix this, so I created a couple of solutions as separate PRs. |
I also notice that the test case given fails when using msvc and ninja backend, I think because |
Thanks @jon-turney! |
@lazka no problem |
Trying to pass a dummy dependency to library() I saw that it is suggested in the dependency() docs that one creates a dependency with name "" and required: false.
but this results in the following error:
What am I doing wrong?
The text was updated successfully, but these errors were encountered: