Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subdir_done is not working inside a condition #3700

Closed
xclaesse opened this issue Jun 6, 2018 · 1 comment
Closed

subdir_done is not working inside a condition #3700

xclaesse opened this issue Jun 6, 2018 · 1 comment

Comments

@xclaesse
Copy link
Member

xclaesse commented Jun 6, 2018

IMO the whole point of subdir_done is to do something like this:

if not dep.found()
  subdir_done()
endif
executable('app', dependencies : dep)

But it's not working, and app fails to build because dep is not found.

@tp-m
Copy link
Member

tp-m commented Jun 6, 2018

Yes, ran into this too the other day. Renders subdir_done() a bit useless.

Can easily be reproduced by modifying the unit test to put it into an if true block.

@tp-m tp-m added this to the meson-next milestone Jun 6, 2018
@tp-m tp-m added the bug label Jun 6, 2018
xclaesse added a commit to xclaesse/meson that referenced this issue Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants