Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meson detects wrong framework for includes on macOS #3793

Closed
ePirat opened this issue Jun 26, 2018 · 1 comment
Closed

Meson detects wrong framework for includes on macOS #3793

ePirat opened this issue Jun 26, 2018 · 1 comment

Comments

@ePirat
Copy link
Contributor

ePirat commented Jun 26, 2018

When detecting the Qt dependency, which are .frameworks on macOS, Meson sometimes detects the wrong .framework and uses that instead of the real one:

c++ -Imodules/modules@@qt_plugin@sha -Imodules -I../VLC/modules -I. -I../VLC/ -I../VLC/include -I/Applications/Qt/5.10.1/clang_64/lib/QtCore.framework.dSYM/Headers -I/Applications/Qt/5.10.1/clang_64/lib/QtGui.framework/Headers -flto -Xclang -fcolor-diagnostics -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=gnu++11 -O2 -g -mmacosx-version-min=10.10 -DHAVE_CONFIG_H=1 -F/Applications/Qt/5.10.1/clang_64/lib -F/Applications/Qt/5.10.1/clang_64/lib  -MD -MQ 'modules/modules@@qt_plugin@sha/gui_qt_dialogs_provider.cpp.o' -MF 'modules/modules@@qt_plugin@sha/gui_qt_dialogs_provider.cpp.o.d' -o 'modules/modules@@qt_plugin@sha/gui_qt_dialogs_provider.cpp.o' -c ../VLC/modules/gui/qt/dialogs_provider.cpp

As you can see, for the include it tries to use /Applications/Qt/5.10.1/clang_64/lib/QtCore.framework.dSYM/Headers in one case, which is the path to the dSYM bundle that contains debug information, not the Qt Core framework.
@ePirat
Copy link
Contributor Author

ePirat commented Jun 26, 2018

Kind of related to a part of #3402

@ePirat ePirat mentioned this issue Jun 26, 2018
Open
ePirat added a commit to ePirat/meson that referenced this issue Jun 26, 2018
@ePirat
Fix ExtraFrameworkDependency Framework detection
e1e3c5c 
The name splitting was wrong and would not incorrectly handle folders
with two dots, like Foo.framework.dSYM and treat this as 'Foo' instead
of 'Foo.framework', which would lead to meson detecting dSYM bundles
as frameworks and try to use those like a framework, which is wrong.

Fix mesonbuild#3793
@ePirat ePirat mentioned this issue Jun 26, 2018
Merged
jpakkane pushed a commit that referenced this issue Jun 26, 2018
@ePirat @jpakkane
Fix ExtraFrameworkDependency Framework detection
3232806 
The name splitting was wrong and would not incorrectly handle folders
with two dots, like Foo.framework.dSYM and treat this as 'Foo' instead
of 'Foo.framework', which would lead to meson detecting dSYM bundles
as frameworks and try to use those like a framework, which is wrong.

Fix #3793
@ePirat ePirat mentioned this issue Sep 4, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ePirat