Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_data() doesn't accept files() object #858

Closed
ignatenkobrain opened this issue Oct 6, 2016 · 3 comments
Closed

install_data() doesn't accept files() object #858

ignatenkobrain opened this issue Oct 6, 2016 · 3 comments
Milestone

Comments

@ignatenkobrain
Copy link
Member

...
plugins = files('example-c.plugin', 'example-python.plugin')
install_data(plugins,
             install_dir : plugin_path)
...
Meson encountered an error in file libdnf/plugins/meson.build, line 3, column 0:
Arguments must be strings.
@TingPing
Copy link
Member

TingPing commented Oct 6, 2016

I personally think they should accept all targets, its a bit silly that you can't pass a custom target to it.

@jpakkane
Copy link
Member

jpakkane commented Oct 7, 2016

Custom target install directives should be in the custom target definition. The design of Meson has been to put as much stuff as possible in one single place. CMake is very annoying because first you define your target and then can have an arbitrary amount of modification commands to it. We want to have everything in one place as much as possible to make things more understandable.

Install_data should accept files so we should fix that.

@nirbheek
Copy link
Member

nirbheek commented Nov 8, 2016

I looked into this, and I don't feel comfortable fixing this without also revamping how we check argument lists in all interpreter functions. It's very ad-hoc with functions and decorators spread across at least three different files with two implementations of the flatten function, and so on. I propose we fix this properly in the next cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants