Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.59 regression: array.contains() method fails for dependency objects #9047

Closed
Akaricchi opened this issue Jul 30, 2021 · 4 comments
Closed

0.59 regression: array.contains() method fails for dependency objects #9047

Akaricchi opened this issue Jul 30, 2021 · 4 comments
Labels
regression
Milestone
0.59.1

Comments

@Akaricchi
Copy link
Contributor

Describe the bug
The contains() method of arrays always returns false when given a dependency object, even if the array actually contains the object. This results in a nasty miscompilation in Taisei.

To Reproduce

project('mesonfail', 'c')
deps = []
dummy = declare_dependency()
deps += dummy
assert(deps.contains(dummy))

Expected behavior
The assertion in the above code snipped must not fail.

system parameters

  • native build
  • openSUSE tumbleweed
  • Python 3.9.0
  • meson 0.59.0
  • ninja 1.10.2
@Akaricchi
Copy link
Contributor Author

May be a duplicate of #9020

@dcbaker dcbaker added this to the 0.59.1 milestone Jul 30, 2021
@dcbaker
Copy link
Member

dcbaker commented Jul 30, 2021

@mensinda

mensinda added a commit to mensinda/meson that referenced this issue Jul 31, 2021
@mensinda
interperter: Fix list contains for Holders (fixes mesonbuild#9020 mes…
1783f74 
…onbuild#9047)
@mensinda
Copy link
Member

Yes, this is almost certainly a duplicate. Could you please check if #9027 fixes this?

mensinda added a commit to mensinda/meson that referenced this issue Jul 31, 2021
@mensinda
interperter: Fix list contains for Holders (fixes mesonbuild#9020 mes…
2f2f241 
…onbuild#9047)
@Akaricchi
Copy link
Contributor Author

Looks like it does.

mensinda added a commit to mensinda/meson that referenced this issue Aug 6, 2021
@mensinda
interpreter: Fix list contains for Holders (fixes mesonbuild#9020 mes…
54b5c9a 
…onbuild#9047)
xclaesse pushed a commit that referenced this issue Aug 9, 2021
@mensinda @xclaesse
interpreter: Fix list contains for Holders (fixes #9020 #9047)
5c87167
@xclaesse xclaesse closed this as completed Aug 9, 2021
nirbheek pushed a commit that referenced this issue Aug 10, 2021
@mensinda @nirbheek
interpreter: Fix list contains for Holders (fixes #9020 #9047)
4ee688a
nirbheek pushed a commit that referenced this issue Aug 10, 2021
@mensinda @nirbheek
interpreter: Fix list contains for Holders (fixes #9020 #9047)
af28005
gicmo added a commit to gicmo/bolt that referenced this issue Aug 16, 2021
@gicmo
ci: pin meson version for fedora based images
97331db 
meson 0.59.0 breaks "contains" for dependency objects[1], which we
use to conditionally set the umockdev ld preload. So this breaks
the umockdev based tests. Since Fedora 33 and above updated to this
version it breaks bolt[2]. Reverse gating tests would be nice.

[1] mesonbuild/meson#9047
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1994006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
0.59.1
Development

No branches or pull requests
4 participants
@Akaricchi @xclaesse @dcbaker @mensinda