IconvBuiltinDependency: BSD Breakage

[haxworx]

Meson is assuming iconv is included with glib.

On non-Linux systems, meson assumed linking against glib.

On BSD link against -liconv

https://github.com/mesonbuild/meson/blob/master/mesonbuild/dependencies/misc.py#L451

Needs to fail on BSD and ensure correct link arguments are passed.

[eli-schwartz]

What is broken about this? It checks for the actual symbols present in the libc, and on at least FreeBSD, there is such a symbol in the libc.

[haxworx]

Ok, you're right, maybe this is a Jenkins issue we are having. Ferme/Close.

…

On Fri, Nov 26, 2021 at 12:05 PM Eli Schwartz ***@***.***> wrote: What is broken about this? It checks for the actual symbols present in the libc, and on at least FreeBSD, there *is* such a symbol in the libc. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9644 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABY44VOL56OMLOC5MYIBUMTUN5ZXVANCNFSM5I2NG7VA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[eli-schwartz]

Note that there is the issue of GNU libiconv, which does require -lintl, installing an iconv.h which may shadow the libc edition, and causes all code which includes that header to try linking to libiconv_open instead of iconv_open. A couple days ago I added a change to make this check also try using iconv.h to ensure it uses the correct version that the project build would see -- the change was broken on at least mingw due to some mysterious effect of meson's has_function check that caused it to think there was a __builtin_iconv_open function provided by the compiler (?????) and #9642 is supposed to fix that.