Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate configure_file(copy : true), and replace it with fs.copyfile #10042

Merged
merged 1 commit into from Aug 18, 2022
Merged

Deprecate configure_file(copy : true), and replace it with fs.copyfile #10042

merged 1 commit into from Aug 18, 2022

Commits on Aug 18, 2022

  1. modules/fs: Replace configure_file(copy:) with fs.copyfile 

    `configure_file` is both an extremely complicated implementation, and
a strange place for copying. It's a bit of a historical artifact, since
the fs module didn't yet exist. It makes more sense to move this to the
fs module and deprecate this `configure_file` version.

This new version works at build time rather than configure time, which
has the disadvantage it can't be passed to `run_command`, but with the
advantage that changes to the input don't require a full reconfigure.
    @dcbaker
    dcbaker committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    59f99dc View commit details
    Browse the repository at this point in the history