-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type annotations cleanup #10248
type annotations cleanup #10248
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10248 +/- ##
==========================================
- Coverage 68.75% 66.08% -2.67%
==========================================
Files 406 203 -203
Lines 87646 43813 -43833
Branches 19486 9575 -9911
==========================================
- Hits 60260 28954 -31306
+ Misses 22848 12606 -10242
+ Partials 4538 2253 -2285
Continue to review full report at Codecov.
|
@lazka seems like the msys2 CI has regressed.
|
We updated to llvm 14 just now. Hm, the logs aren't very helpful. |
If I run this locally I get:
|
It's this I think: llvm/llvm-project#53950, so likely msys2 is the first llvm 14 user in CI? |
I've filed #10249 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to review this, looks good to me.
In commit f2d21bf a type annotation was added that does not exist. The referenced type is present but only as a dotted name.
Did a clean rebase to retrigger CI with the llvm 14 fix. EDIT: Okay, in exchange we get a windows 2016 brownout lol. |
One minor fix for a broken annotation. Various stuff moved to typing-only imports.