Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type annotations cleanup #10248

Merged
merged 3 commits into from
May 23, 2022
Merged

type annotations cleanup #10248

merged 3 commits into from
May 23, 2022

Conversation

eli-schwartz
Copy link
Member

One minor fix for a broken annotation. Various stuff moved to typing-only imports.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #10248 (26fe41f) into master (5d0538d) will decrease coverage by 2.66%.
The diff coverage is n/a.

❗ Current head 26fe41f differs from pull request most recent head 1c52ac4. Consider uploading reports for the commit 1c52ac4 to get more accurate results

@@            Coverage Diff             @@
##           master   #10248      +/-   ##
==========================================
- Coverage   68.75%   66.08%   -2.67%     
==========================================
  Files         406      203     -203     
  Lines       87646    43813   -43833     
  Branches    19486     9575    -9911     
==========================================
- Hits        60260    28954   -31306     
+ Misses      22848    12606   -10242     
+ Partials     4538     2253    -2285     
Impacted Files Coverage Δ
scripts/run_tool.py 0.00% <0.00%> (-100.00%) ⬇️
scripts/clangtidy.py 0.00% <0.00%> (-93.34%) ⬇️
modules/unstable_cuda.py 0.00% <0.00%> (-72.50%) ⬇️
templates/cudatemplates.py 37.50% <0.00%> (-62.50%) ⬇️
scripts/clangformat.py 0.00% <0.00%> (-54.84%) ⬇️
compilers/cuda.py 19.38% <0.00%> (-45.54%) ⬇️
dependencies/cuda.py 20.19% <0.00%> (-42.79%) ⬇️
compilers/d.py 37.23% <0.00%> (-19.28%) ⬇️
cmake/generator.py 48.14% <0.00%> (-11.12%) ⬇️
cmake/executor.py 58.08% <0.00%> (-6.59%) ⬇️
... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0538d...1c52ac4. Read the comment docs.

@eli-schwartz
Copy link
Member Author

@lazka seems like the msys2 CI has regressed.

[UNEXSKIP]   frameworks: 15 llvm    (method=cmake link-static=True)
 [SUCCESS]   frameworks: 15 llvm    (method=config-tool link-static=False)
 [SUCCESS]   frameworks: 15 llvm    (method=config-tool link-static=True)

@lazka
Copy link
Contributor

lazka commented Apr 8, 2022

We updated to llvm 14 just now. Hm, the logs aren't very helpful.

@lazka
Copy link
Contributor

lazka commented Apr 8, 2022

If I run this locally I get:

 [SKIPPED]   frameworks: 15 llvm    (method=cmake link-static=True)
Reason: llvm not found.
 [SUCCESS]   frameworks: 15 llvm    (method=config-tool link-static=False)
 [SUCCESS]   frameworks: 15 llvm    (method=config-tool link-static=True)

@lazka
Copy link
Contributor

lazka commented Apr 8, 2022

It's this I think: llvm/llvm-project#53950, so likely msys2 is the first llvm 14 user in CI?

@lazka
Copy link
Contributor

lazka commented Apr 8, 2022

I've filed #10249

Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to review this, looks good to me.

In commit f2d21bf a type annotation was
added that does not exist. The referenced type is present but only as a
dotted name.
@eli-schwartz
Copy link
Member Author

eli-schwartz commented May 23, 2022

Did a clean rebase to retrigger CI with the llvm 14 fix.

EDIT: Okay, in exchange we get a windows 2016 brownout lol.

@eli-schwartz eli-schwartz merged commit 1c52ac4 into mesonbuild:master May 23, 2022
@eli-schwartz eli-schwartz deleted the typing branch May 23, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants