hotdoc module: add dedicated depends kwarg, deprecate file deps in dependencies #10982
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10982 +/- ##
==========================================
+ Coverage 65.10% 68.33% +3.22%
==========================================
Files 207 412 +205
Lines 44893 87813 +42920
Branches 9275 20716 +11441
==========================================
+ Hits 29229 60007 +30778
- Misses 13369 23308 +9939
- Partials 2295 4498 +2203
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@jpakkane this fixes a regression in the release candidate which makes |
|
@eli-schwartz @jpakkane would be nice to finalize this, I think it is release blocker. |
|
I think it's ready to merge, actually... It seems unnecessary to carry around deprecated support for something that should never happen, and the reasonable use case is maintained, right? |
|
Deprecation warning for something that projects should stop doing is the whole point of this PR. If you don't agree with that why did you make at all? |
|
Fixing half the problem is completely useless, the whole point is to keep GST working. |
|
Hmm, actually yes it is useful because it gives a way to make GST work with both old and new meson. Good enough I guess. |
|
Well yes, I was making a distinction between "wanted to do X, X needs new kwargs, keep that working on old versions" and "this particular bit here was apparently wrong for old versions too". :D |
|
@jpakkane this needed to go in before the final release. Also several PRs to fix CI are still pending, how did you successfully release it? :D |
Internally we pass this as extra_depends to the CustomTarget initializer, so it makes sense to call it that rather than confusing the topic by referring to "dependencies", a term that indicates CFLAGS/LDFLAGS interfaces.
…pendencies We consistently use the "dependencies" kwarg to refer to C-like CFLAGS/LDFLAGS interfaces. And for hotdoc, we actually accept libraries for this as well, as we may want to document their (generated?) sources, so we want their CFLAGS too. But we also accepted custom targets and just added a build order dependency on these, which was odd and typically we call that "depends". Let's deprecate this in favor of the depends kwarg.
eli-schwartz
force-pushed
the
hotdoc-depends
branch
from
231731c
to
28bfa75
Compare
We consistently use the "dependencies" kwarg to refer to C-like CFLAGS/LDFLAGS interfaces. And for hotdoc, we actually accept libraries for this as well, as we may want to document their (generated?) sources, so we want their CFLAGS too.
But we also accepted custom targets and just added a build order dependency on these, which was odd and typically we call that "depends". Let's deprecate this in favor of the depends kwarg.