allow empty name_suffix
#11001
Open
allow empty name_suffix
#11001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dot is still present at end of file name if suffix is empty. More work needed. |
|
Wouldn't the correct file extension for kernel modules actually be |
This is true for Linux, but not necessary for another operating systems. For example in Haiku kernel modules have no any prefix or suffix and module file name is used to find requested module. Haiku also do not use any prefix or suffix for various system extension plugins (add-ons) and userspace drivers. |
It is required for plugins and kernel modules that are looked up by file name and require to specify exact file name. Some plugin systems do not use any prefix or suffix.
tristan957
reviewed
Nov 14, 2022
| @@ -1818,25 +1816,27 @@ def post_init(self) -> None: | |||
| if not hasattr(self, 'suffix'): | |||
| # Executable for Windows or C#/Mono | |||
| if machine.is_windows() or machine.is_cygwin() or 'cs' in self.compilers: | |||
| self.suffix = 'exe' | |||
| self.suffix = '.exe' | |||
There was a problem hiding this comment.
I think it would be best not to change this. Instead where the suffix is concatenated to the file name, conditionally add a dot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is required for plugins and kernel modules that are looked up by file name and require to specify exact file name. Some plugin systems do not use any prefix or suffix.