Add a dependencies keyword argument to bindgen
#11024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/bindgen-dependencies
branch
from
96e2ef3
to
0fe3add
Compare
Codecov Report
@@ Coverage Diff @@
## master #11024 +/- ##
==========================================
- Coverage 68.58% 59.33% -9.26%
==========================================
Files 412 207 -205
Lines 87861 44941 -42920
Branches 20728 9288 -11440
==========================================
- Hits 60261 26664 -33597
+ Misses 23093 16049 -7044
+ Partials 4507 2228 -2279
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tristan957
reviewed
Nov 15, 2022
|
Turns out we actually need this one in mesa already as once valgrind is enabled, we have to pull in the dep to resolve build errors. |
dcbaker
force-pushed
the
submit/bindgen-dependencies
branch
from
0fe3add
to
3c73f38
Compare
dcbaker
force-pushed
the
submit/bindgen-dependencies
branch
2 times, most recently
from
2a61c0b
to
0d79ab6
Compare
This is needed for cases where we need external C headers, which are passed to clang.
dcbaker
force-pushed
the
submit/bindgen-dependencies
branch
from
0d79ab6
to
d49e6bc
Compare
PedroHLC
pushed a commit
to chaotic-cx/mesa-mirror
that referenced
this pull request
Jan 30, 2023
This bumps the meson requierement to 1.0 because it requires mesonbuild/meson#11024 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7688 Fixes: 20c90fe ("rusticl: added") Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19778>
PedroHLC
pushed a commit
to chaotic-cx/mesa-mirror
that referenced
this pull request
Jan 31, 2023
This bumps the meson requierement to 1.0 because it requires mesonbuild/meson#11024 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7688 Fixes: 20c90fe ("rusticl: added") Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19778> (cherry picked from commit 4b841cf) Conflicts: .gitlab-ci/image-tags.yml
PedroHLC
pushed a commit
to chaotic-cx/mesa-mirror
that referenced
this pull request
Jan 31, 2023
This bumps the meson requierement to 1.0 because it requires mesonbuild/meson#11024 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7688 Fixes: 20c90fe ("rusticl: added") Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19778> (cherry picked from commit 4b841cf) Conflicts: .gitlab-ci/image-tags.yml Stable: - Create a custom CI tag for 23.0, as we're lacking some patches necessary to use the same CI images as main, and I don't want to pull that many CI changes into the stable branch
PedroHLC
pushed a commit
to chaotic-cx/mesa-mirror
that referenced
this pull request
Jan 31, 2023
This bumps the meson requierement to 1.0 because it requires mesonbuild/meson#11024 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7688 Fixes: 20c90fe ("rusticl: added") Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19778> (cherry picked from commit 4b841cf) Conflicts: .gitlab-ci/image-tags.yml Stable: - Create a custom CI tag for 23.0, as we're lacking some patches necessary to use the same CI images as main, and I don't want to pull that many CI changes into the stable branch
PedroHLC
pushed a commit
to chaotic-cx/mesa-mirror
that referenced
this pull request
Feb 2, 2023
This bumps the meson requierement to 1.0 because it requires mesonbuild/meson#11024 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7688 Fixes: 20c90fe ("rusticl: added") Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19778> (cherry picked from commit 4b841cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing
dependencyobjects to therust.bindgenmethod. This is useful when the header you're generating bindings for includes system headers, and needs to pass include flags to clang from said dependencies. In addition we can create correct ordering for generated sources in aninternal_dependencyfor the bindgen callThis includes #11062, but that PR should be merged first because it needs backport, while the rest of this doesn't.