Add a system method for obtaining GL dependency on Linux OS #11559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we remove the conditional in |
eli-schwartz
previously requested changes
Mar 22, 2023
|
Thanks. Meson has a policy to prefer |
|
Ah yes, no problem. I notice Github is still saying 'changes requested' from you, but I can't see what they are. I assume you're not waiting for me to do anything. |
eli-schwartz
dismissed
their stale review
The review has been resolved and the changes are outdated and replaced by the good stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion #11554 highlighting the fact that although MacOS X and Windows have a special implementation to acquire the 'system' GL library, Linux does not (it may not even be shipped with the system).
This pull request provides an option for Linux operating systems to query the C compiler directly for the GL library, and then assigns the returned flags to this dependency, if it is found.