meson: add color to clang-cl #11648
meson: add color to clang-cl #11648
Conversation
Both fcolor-diagnostics and fansi-escape-codes are needed Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
CI failures seem unrelated. |
-openmp:llvm is needed to link. Signed-off-by: Rosen Penev <rosenp@gmail.com>
| @@ -62,6 +62,12 @@ | |||
| 'neon': None, | |||
| } # T.Dicst[str, T.Optional[T.List[str]]] | |||
|
|
|||
| clang_color_args = { | |||
| 'auto': ['-fcolor-diagnostics', '-fansi-escape-codes'], | |||
| 'always': ['-fcolor-diagnostics', '-fansi-escape-codes'], | |||
There was a problem hiding this comment.
This does not seem right. auto and always do not mean the same thing, thus it is hard to believe they can be implemented in the same way. auto means use colors unless stdout is not a terminal, always means always use colors. Using the same compiler options for both means that either you get escape sequences emitted when stdout is not a tty when auto is used, or you don't get them in the same situation when always is used.
There was a problem hiding this comment.
This is copied from what is present in clang
There was a problem hiding this comment.
If I read correctly the documentation https://clang.llvm.org/docs/UsersManual.html#cmdoption-f-no-color-diagnostics this patch is not necessary. In particular, I think that enabling ansi escape codes on Windows is a bad idea.
There was a problem hiding this comment.
Because the Windows terminal does not understand ansi escape codes.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Not listening to anything ChatGPT says, it's not a trustworthy source.
There was a problem hiding this comment.
It's answer was correct here. cmd.exe does support ANSI escape codes.
There was a problem hiding this comment.
It supports it if you explicitly enable it. It is not the default, thus it cannot be Meson default to emit ansi escape codes that will be shown as unreadable output for most users. Also, I don't think that enabling the ansi escapes codes in the Windows 10 command prompt disables the Windows Console API, thus I don't see why it is desirable to enable this option by default. The commit message says that the -fansi-escape-codes is required, but it does not look like this.
There was a problem hiding this comment.
Anyway, this PR came out of https://github.com/mesonbuild/wrapdb/blob/master/subprojects/packagefiles/check/meson.build#L35 , which should be default.
Both fcolor-diagnostics and fansi-escape-codes are needed