Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "backends: Cache creation of install data" #11959

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

eli-schwartz
Copy link
Member

This reverts commit 904b470.

This is not a real bottleneck, and we want to create it thrice -- once before the backend is generated. The final install data needs to be created fresh.

Fixes https://bugs.gentoo.org/910050

@eli-schwartz eli-schwartz added this to the 1.2.0 milestone Jul 9, 2023
@eli-schwartz
Copy link
Member Author

Also fails in Debian via @helmutg's "rebuild Debian with the meson release candidate and see what breaks":

# buildlogs/cinnamon_5.6.8-1

Installing src/libcinnamon.so to /<<PKGBUILDDIR>>/debian/tmp/usr/lib/x86_64-linux-gnu/cinnamon
New rpath must not be longer than the old one.
 Old: $ORIGIN/st:/usr/lib/x86_64-linux-gnu/muffin:XXXXXXXXXXXXXXXXXXXXXXXX
 New: /usr/lib/x86_64-linux-gnu/muffin:/usr/lib/x86_64-linux-gnu/cinnamon:$ORIGIN/st

This reverts commit 904b470.

This is not a real bottleneck, and we want to create it thrice -- once
before the backend is generated. The final install data needs to be
created fresh.

Update unittest to demonstrate the issue.

Fixes https://bugs.gentoo.org/910050
@eli-schwartz
Copy link
Member Author

Found a testcase, updated.

@jpakkane jpakkane merged commit 4166bf1 into mesonbuild:master Jul 10, 2023
34 checks passed
@eli-schwartz eli-schwartz deleted the installdata-gedit branch July 10, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants