dedup linked libs #12276
Draft
dedup linked libs #12276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure -L order is preserved. This results in a 10% smaller build.ninja file on my project.
xclaesse
reviewed
Sep 29, 2023
| @@ -267,12 +269,15 @@ def extend_preserving_lflags(self, iterable: T.Iterable[str]) -> None: | |||
| normal_flags = [] | |||
| lflags = [] | |||
| for i in iterable: | |||
| if i not in self.always_dedup_args and (i.startswith('-l') or i.startswith('-L')): | |||
| if i not in self.always_dedup_args and (i.startswith('-l') or i.startswith('-L')) and i not in self._libs: | |||
There was a problem hiding this comment.
I'm never sure about -lfoo order, shouldn't we keep last occurrence instead of first?
There was a problem hiding this comment.
I'm really not sure myself. Probably it should keep the last occurence, because as libs are visited, symbols to be linked are accumulated. But in that case, -L order may become wrong... And there may be linkers that requires to have some libs duplicated for static linking, in case of circular references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure -L order is preserved. This results in a 10% smaller build.ninja file on my project.