Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msvc: Do not include pch obj when b_pch=false #12498

Merged
merged 1 commit into from
Nov 10, 2023
Merged

msvc: Do not include pch obj when b_pch=false #12498

merged 1 commit into from
Nov 10, 2023

Conversation

xclaesse
Copy link
Member

Fixes: #12494

@xclaesse xclaesse mentioned this pull request Nov 10, 2023
Closed
@xclaesse xclaesse added this to the 1.3.0 milestone Nov 10, 2023
@xclaesse
Copy link
Member Author

CI failure should be fixed by #12499

@xclaesse xclaesse merged commit 42898bb into mesonbuild:master Nov 10, 2023
33 of 34 checks passed
@xclaesse xclaesse deleted the fix-pch-msvc branch November 10, 2023 19:04
@nirbheek nirbheek modified the milestones: 1.3.0, 1.2.4 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristan957 tristan957 tristan957 approved these changes

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.

b_pch=false option doesn't work correctly on 'Developer Powershell for VS' shell with Meson v.1.2.0 and after
3 participants
@xclaesse @tristan957 @nirbheek