Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that alias_target accepts run_tgts since 0.60.0 #12783

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

tristan957
Copy link
Contributor

This was accidentally changed in
982973f, when alias_target was changed to use typed_pos_args.

@tristan957
Copy link
Contributor Author

cc @dcbaker

@dcbaker
Copy link
Member

dcbaker commented Jan 26, 2024

Looks good to me otherwise

@dcbaker
Copy link
Member

dcbaker commented Jan 26, 2024

the website failure also looks relavent

@tristan957
Copy link
Contributor Author

Oh whoops. I'll check it out when it re-spins

@tristan957
Copy link
Contributor Author

I think I was just missing the @

@dcbaker
Copy link
Member

dcbaker commented Jan 26, 2024

The if any... line looks like it's not indented enough

@tristan957
Copy link
Contributor Author

Ahh. I just committed your suggestion. One second.

@eli-schwartz
Copy link
Member

This was accidentally changed in
982973f, when alias_target was changed to use typed_pos_args.

Nothing accidental about its support it was broken even in that PR, but I fixed it and added a testcase: #9202

https://mesonbuild.com/Release-notes-for-0-60-0.html#run_target-can-now-be-used-as-a-dependency

I did not add a FeatureNew though... oops.

@tristan957
Copy link
Contributor Author

I will reword the commit message.

This was implemented in dc51740,
but was not added to the documentation or marked as a new feature.
@eli-schwartz eli-schwartz merged commit b08d531 into mesonbuild:master Feb 9, 2024
35 checks passed
@nirbheek nirbheek modified the milestones: 1.3.3, 1.3.2 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants