bytecompile: process .py files in deterministic order #12788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, Setzer produced random variations. It probably matters because of the way python does things dumping internal structures into .pyc files. This patch was done while working on reproducible builds for openSUSE.
|
.pyc file diff contained -p/home/abuild/rpmbuild/BUILDROOT/Setzer-65-0.0.x86_64/usr/lib/python3.11/site-packages/setzer/dialogs/__init__.py
+</usr/lib/python3.11/site-packages/setzer/dialogs/__init__.pywhich might indicate that there is some other problem when it cannot decide which path to use. The shorter one would probably be correct. |
|
That indicates the ddir being passed is incorrect. |
|
@bmwiedemann I believe the correct fix is actually master...eli-schwartz:meson:pycompile-destdir, please test. |
|
Yes, your version is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, Setzer produced random variations in .pyc files.
It probably matters because of the way python does things - dumping internal structures into .pyc files.
This patch was done while working on reproducible builds for openSUSE.