Add required kwarg to compiler.{compiles,links,run} #13137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
force-pushed
the
compiles
branch
3 times, most recently
from
55de8a9
to
8056011
Compare
QuLogic
reviewed
Apr 25, 2024
docs/markdown/snippets/requires_kwarg_on_more_compiler_methods.md
Outdated
Show resolved
Hide resolved
tristan957
force-pushed
the
compiles
branch
2 times, most recently
from
d46e8e1
to
d52e1f6
Compare
dcbaker
approved these changes
Apr 25, 2024
|
Can you rebase this, then it's ready to land I think |
This is a similar commit to the one that added required to all the compiler.has* functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a similar commit to the one that added required to all the compiler.has* functions.