Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass wrapmode value around a a string. #13229

Merged
merged 1 commit into from
May 19, 2024
Merged

Pass wrapmode value around a a string. #13229

merged 1 commit into from
May 19, 2024

Conversation

jpakkane
Copy link
Member

Because the return value of get_option can be WrapMode, every single place where options are used need to handle WrapMode.

This MR changes it to be a basic string combo, which gets transformed into a WrapMode only at the point where it is actually used.

This simplifies things for the option rewrite branch.

@jpakkane
Copy link
Member Author

Test failures are unrelated and in other MRs too.

@jpakkane jpakkane merged commit 128f0e8 into master May 19, 2024
35 of 39 checks passed
@jpakkane jpakkane deleted the wrapmodeoption branch May 19, 2024 17:58
soumyaDghosh pushed a commit to soumyaDghosh/meson that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant