-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new linter warnings. #13233
Fix new linter warnings. #13233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already have a PR for this. I didn't get a chance to push a couple more commits before the weekend.
The changes here are actually wrong though.
In which way? |
pylint is also incapable of analyzing when variables will exist in multiple conditional blocks using the same conditional, and I don't believe the solution is to add code that fails mypy strict-optional just to make pylint happy with a check that is very prone to false positives. |
No description provided.