remove deprecation warning for configure_file kwarg 'copy'
#13250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm? Ok, granted I get where you're coming from by wanting to revert this change, but still :D |
It's okay, it wasn't too unpleasant 😁 |
|
Well, I still wonder if it's a good fit for the commit message? Also the body paragraph should really be line wrapped. |
|
I'll rewrite the commit message and remove the word 'chore' 😄, and I'll wrap the body (made this PR directly in GH so forgot to wrap... oops). Apart from that is the commit message fine? |
mcdurdin
changed the title
configure_file kwarg 'copy'configure_file kwarg 'copy'
`configure_file` kwarg `copy` runs at configure time, whereas `fs.copyfile` runs at build time. Both have use cases, so this undeprecates the `configure_file` version. Fixes: mesonbuild#12792
eli-schwartz
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure_filekwargcopyruns at configure time, whereasfs.copyfileruns at build time. Both have use cases, so this undeprecates theconfigure_fileversion.Fixes: #12792