Fix cross environment pollution. #1807
Conversation
|
Note: I realized my commit message style of the previous two PRs were |
|
This needs a unit test to ensure it won't get broken again. This requires creating a new unit test class, say |
oleavr
force-pushed
the
cross-environment-pollution
branch
2 times, most recently
from
d76d2b9
to
1b311f0
Compare
|
@jpakkane Done. |
oleavr
force-pushed
the
cross-environment-pollution
branch
from
1b311f0
to
3b6ed52
Compare
run_tests.py
Outdated
| @@ -153,7 +153,7 @@ def is_cross_build(self): | |||
| print('Running unittests.\n') | |||
| units = ['InternalTests', 'AllPlatformTests'] | |||
| if mesonlib.is_linux(): | |||
| units += ['LinuxlikeTests'] | |||
| units += ['LinuxlikeTests', 'LinuxArmCrossCompileTests'] | |||
There was a problem hiding this comment.
These cross tests should only be done if the cross toolchain is installed. In run_tests it is done like this (at the end of the file):
shutil.which('arm-linux-gnueabihf-gcc-6') and not platform.machine().startswith('arm')
This should be extracted to a function should_run_linux_cross_tests() and used from both locations.
There was a problem hiding this comment.
@jpakkane Ahh nice catch! Thanks, will fix.
Environment variables like CFLAGS and LDFLAGS should not affect the cross environment. Fixes mesonbuild#1772
oleavr
force-pushed
the
cross-environment-pollution
branch
from
3b6ed52
to
383e561
Compare
|
@jpakkane Fixed (hopefully). |
- generate cross-file per package, needed since mesonbuild/meson#1807 to use changed build-flags
Environment variables like CFLAGS and LDFLAGS should not affect the
cross environment.
Fixes #1772