Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output an appropriate warning when a cross info file does not exist. #2021

Merged
merged 2 commits into from Jul 2, 2017
Merged

Output an appropriate warning when a cross info file does not exist. #2021

merged 2 commits into from Jul 2, 2017

Commits on Jul 1, 2017

  1. Output an appropriate warning when a cross info file does not exist. 

    If making a typo, it used to output:
>  Cross info file must have either host or a target machine.
This was not useful at all and looked like there could be a file format
error or some other issue with the content. Let's have an appropriate
error:
> File not found: /some/path
    Jehan committed Jul 1, 2017
    Copy the full SHA
    1b6d6b6 View commit details
    Browse the repository at this point in the history

  2. Improve "Passed invalid keyword argument" warning. 

    I got this warning on a build:
> WARNING: Passed invalid keyword argument preset. This will become a hard error in the future.
I had to grep in meson code to understand that "preset" was the name of
the invalid argument. This is not obvious at all depending on the
argument name (here it looked like it was about argument presets).
Let's make it clearer by putting it in quotes.
    Jehan committed Jul 1, 2017
    Copy the full SHA
    38f2e1f View commit details
    Browse the repository at this point in the history