Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure_file: warn in case a variable to subsitute is not present i… #2094

Merged
merged 1 commit into from Jul 21, 2017

Conversation

lazka
Copy link
Contributor

@lazka lazka commented Jul 20, 2017

…n the passed configuration. Fixes #2090

I could't find any unit tests for the affected functions, so no tests atm, ideas where to put them welcome.

@codecov-io
Copy link

codecov-io commented Jul 21, 2017

Codecov Report

Merging #2094 into master will increase coverage by 7.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2094      +/-   ##
==========================================
+ Coverage   56.29%   63.91%   +7.61%     
==========================================
  Files          72       72              
  Lines       17164    17172       +8     
  Branches     3536     3537       +1     
==========================================
+ Hits         9663    10976    +1313     
+ Misses       6404     5103    -1301     
+ Partials     1097     1093       -4
Impacted Files Coverage Δ
mesonbuild/interpreter.py 74.49% <100%> (+0.03%) ⬆️
mesonbuild/mesonlib.py 81.72% <100%> (+0.77%) ⬆️
mesonbuild/dependencies/ui.py 71.14% <0%> (+0.28%) ⬆️
mesonbuild/compilers/fortran.py 69.41% <0%> (+1.76%) ⬆️
mesonbuild/mintro.py 54.73% <0%> (+2.1%) ⬆️
mesonbuild/compilers/compilers.py 79.93% <0%> (+2.15%) ⬆️
mesonbuild/modules/__init__.py 90.14% <0%> (+2.81%) ⬆️
mesonbuild/build.py 76.97% <0%> (+3.61%) ⬆️
mesonbuild/backend/ninjabackend.py 88.15% <0%> (+3.77%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26834a6...99206b6. Read the comment docs.

@lazka lazka force-pushed the configure-file-missing-vars branch from f6f52a9 to 99206b6 Compare July 21, 2017 11:29
@jpakkane
Copy link
Member

This is just a FYI warning to users, we don't require tests for those. Thanks.

@jpakkane jpakkane merged commit ceea746 into mesonbuild:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants