llvm: fix static linking #2595
Merged
llvm: fix static linking #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I left a hack patch in a pull request for LLVM, and the result is that LLVM doesn't link with static builds. The real problem was that some distros have pkg-config for tinfo, other's don't, so the correct solution is to use cpp_compiler.find_library if dependency() fails.
|
@jpakkane this fixes a bug in the LLVM series from me you just merged. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left a hack patch in a pull request for LLVM, and the result is that
LLVM doesn't link with static builds. The real problem that needed
to be solved is that some distros have pkg-config for tinfo, other's
don't, so the correct solution is to use cpp_compiler.find_library if
dependency() fails.