Factor out code for windows abi tags. #3004
Conversation
mesonbuild/dependencies/misc.py
Outdated
| if mesonlib.for_windows(self.want_cross, self.env): | ||
| comp_ts_version = self.env.detect_cpp_compiler(self.want_cross).get_toolset_version() | ||
| compiler_ts = comp_ts_version.split('.') | ||
| #FIXME - what about other compilers? |
There was a problem hiding this comment.
[Flake8]
[E265] block comment should start with '# '
mesonbuild/dependencies/misc.py
Outdated
| #FIXME - what about other compilers? | ||
| tag = 'vc{}{}'.format(compiler_ts[0], compiler_ts[1]) | ||
|
|
||
| tag = '-' + tag; |
There was a problem hiding this comment.
[Flake8]
[E703] statement ends with a semicolon
mesonbuild/dependencies/misc.py
Outdated
| # FIXME - how to handle different distributions, e.g. for Mac? Currently we handle homebrew and macports, but not fink. | ||
| def abi_tag(self): | ||
| if mesonlib.for_windows(self.want_cross, self.env): | ||
| tag = self.compiler_tag()+self.threading_tag() |
There was a problem hiding this comment.
[Flake8]
[E226] missing whitespace around arithmetic operator
bredelings
force-pushed
the
clean-boost
branch
from
ba153f9
to
4f54451
Compare
|
The boost failure does seem relevant as ABI tags may be confusing the lookup logic somehow. |
bredelings
force-pushed
the
clean-boost
branch
from
4f54451
to
ead0263
Compare
mesonbuild/dependencies/misc.py
Outdated
| # FIXME - how to handle different distributions, e.g. for Mac? Currently we handle homebrew and macports, but not fink. | ||
| def abi_tag(self): | ||
| if mesonlib.for_windows(self.want_cross, self.env): | ||
| # PROBLEM: mingw just uses self.threading_tag() |
There was a problem hiding this comment.
[Flake8]
[W291] trailing whitespace
|
Fixes #2990 |
|
Fixes #2631 |
|
@jpakkane This series
This cleanup allows me to cross-compile from linux to windows using mingw-w64, which several people have filed issues about. What do you think? |
|
@nirbheek Any comments? |
|
I can't review in detail, but this sounds good to me in principle. Maybe @NickeZ can review? |
|
Given that Boost is ununderstandable, I'm fine with merging this since it fixes an important use case. Any objections? |
No description provided.