WIP: accept dirafter as system arg to include_directories #3142
Conversation
mesonbuild/interpreter.py
Outdated
| [self.interpreter.backend.get_target_private_dir(self.held_object)])) | ||
| extra_build_dirs = [self.interpreter.backend.get_target_private_dir(self.held_object)] | ||
| return IncludeDirsHolder( | ||
| build.IncludeDirs('', [], False, False, |
There was a problem hiding this comment.
[Flake8]
[E126] continuation line over-indented for hanging indent
|
Btw, this could be useful to me for trying out meson with a really old project that has several such name clashes. |
|
It seems like msvc has added support for system headers: https://blogs.msdn.microsoft.com/vcblog/2017/12/13/broken-warnings-theory/ |
|
This looks like a useful feature, will you be continuing work on this to get it out of WIP status? |
|
Sure if I can get some hints on what the API should look like. If the current one is OK I can take a look at it again and see if it is reviewable.. |
|
Two things:
|
|
I need this for a project of mine. @NickeZ would you revive this PR, or should I make a new one myself? For the syntax, I would suggest |
|
@bugaevc feel free to pick it up. I don't have any time to work on this right now as I don't need it anymore. |
This allows you to include directories after the system directories. Which means that you can have header files which have the same name as system headers and but not override them.
Not sure if this is the proper solution though. It should probably be an enum, (regular, system or dirafter).
Fixes #3141