Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesonbuild: Recognise risc-v architecture #3889

Merged
merged 1 commit into from Jul 21, 2018
Merged

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Jul 14, 2018

Signed-off-by: Khem Raj raj.khem@gmail.com

@rossburton
Copy link
Contributor

Do those names match what platform.machine() gives under Python on target?

@rossburton
Copy link
Contributor

Also to make the CI pass, you need to expand the documentation too.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@kraj
Copy link
Contributor Author

kraj commented Jul 21, 2018

@rossburton thanks, fixed now

@jpakkane
Copy link
Member

Are you aware if these names are what all other build systems et al use for RISCV or are there some other terms as well?

@kraj
Copy link
Contributor Author

kraj commented Jul 21, 2018

riscv32 support is just being added to glibc so not many distros are out there yet and riscv64 is common yes.

@jpakkane
Copy link
Member

And the glibc names are riscv32 and riscv64?

@jpakkane
Copy link
Member

And to highlight this question from above:

Do those names match what platform.machine() gives under Python on target?

@kraj
Copy link
Contributor Author

kraj commented Jul 21, 2018

Here is output from python on qemuriscv64

root@qemuriscv64:~# python
Python 2.7.15 (default, Jul 21 2018, 18:17:04)
[GCC 8.1.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform
>>> print platform.machine()
riscv64
>>>

@jpakkane jpakkane merged commit 6fafbad into mesonbuild:master Jul 21, 2018
@jpakkane
Copy link
Member

Great, thanks.

@nirbheek nirbheek added this to the 0.47.2 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants