Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PkgConfigDependency: Parse library paths in a separate step #4061

Merged
merged 1 commit into from
Aug 21, 2018
Merged

PkgConfigDependency: Parse library paths in a separate step #4061

merged 1 commit into from
Aug 21, 2018

Commits on Aug 20, 2018

  1. PkgConfigDependency: Parse library paths in a separate step 

    pkg-config and pkgconf treat additional search paths in
PKG_CONFIG_PATH and PKG_CONFIG_LIBDIR differently when
PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 is set.

pkg-config always outputs -L flags for the additional paths first, and
pkgconf always outputs -L flags for the default paths first.

To account for this inconsistency, we now sort the library paths into
two separate sets: system (default) and prefix (additional) paths. We
can do this because we always query pkg-config twice: once with
PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 set and once without it.

Then, we ensure that the prefix paths are searched before the system
paths.

Closes #4023
Closes #3951
    @nirbheek
    nirbheek committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    b12d72d View commit details
    Browse the repository at this point in the history