WIP RFC gnome.py cross improvements #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
textshell
reviewed
Sep 25, 2018
mesonbuild/backend/ninjabackend.py
Outdated
| @@ -1396,7 +1396,7 @@ def generate_dynamic_link_rules(self, outfile): | |||
| rspfile_content = $ARGS {output_args} $in $LINK_ARGS {cross_args} $aliasing | |||
| ''' | |||
| else: | |||
| command_template = ' command = {executable} $ARGS {output_args} $in $LINK_ARGS {cross_args} $aliasing\n' | |||
| command_template = ' command = {executable} $ARGS {cross_args} {output_args} $in $LINK_ARGS $aliasing\n' | |||
There was a problem hiding this comment.
Please don't make such changes in an aside without rational. Argument ordering in one of those places that might or might not have consequences.
There was a problem hiding this comment.
I can't replicate the failures we were seeing, dropped and will bring it back with more proof if I can break it again.
rossburton
force-pushed
the
cross
branch
2 times, most recently
from
f22a02a
to
84fd331
Compare
|
Rebased, squashed, and wrote nice messages. |
Instead of showing just the command invoked, it's useful when debugging to also show all of the arguments.
When cross-compiling the gtk-doc calls were missing the configured c_args and c_link_args.
…iling When cross-compiling we shouldn't be passing the native c_args/c_link_args to g-ir-scanner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.