add clang c_std=c18 alias #5560
Conversation
scivision
force-pushed
the
cstd18_bug
branch
3 times, most recently
from
fc66f4a
to
14a43d2
Compare
|
This is the one commit that is new. I seem to have bobbled the rebase and previously merged master commits show up here: |
|
Probably you started from your previous PR's state and it got merged in the meantime. Just make sure your |
|
The CI had passed, I rebased on upstream/master but the previous master commits are still showing. This has happened to me before soometimes and I don't think it was any issue to merge. The commits tab of this PR https://github.com/mesonbuild/meson/pull/5560/commits shows the one commit for this PR. |
|
It's correct now; it was definitely wrong before (I pulled your previous commits to check.) |
|
OK @QuLogic it might have been that I needed to wait a minute or something before refreshing. Now I see that GitHub PR "Files Changed" tab shows what you're saying, just the single commit is needed. I think this is ready to merge then. |
fix unit test skips for clang c18 correct unittests clang minimum version cleanup unittest clang skip c_std finesse unittest vs. clang version
|
LGTM, feel free to merge if you think it's ok. |
Fixes #5539
tested on Linux and Windows, Clang 6.0.0 and 8.0.0
Also with Intel C compiler.
Cleaned up c_stds test in run_unittests.py so that's it's readable, correct and deduped.