Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtkdoc: Add 'check' kwarg #5591

Merged
merged 3 commits into from Jul 16, 2019
Merged

gtkdoc: Add 'check' kwarg #5591

merged 3 commits into from Jul 16, 2019

Conversation

xclaesse
Copy link
Member

@xclaesse xclaesse commented Jul 2, 2019

This runs gtkdoc-check in meson tests.

@ocrete
Copy link

ocrete commented Jul 2, 2019

In libnice, I also need to set SRCDIR=... and BUILDDIR=... in the env when running it

@xclaesse
Copy link
Member Author

xclaesse commented Jul 3, 2019

In libnice, I also need to set SRCDIR=... and BUILDDIR=... in the env when running it

Are you sure? Why would it need that? Checking the code of gtkdoc-check and I don't see it using those env.

@xclaesse xclaesse force-pushed the gtkdoc-check branch 4 times, most recently from a4c0c2b to 9f9a545 Compare July 3, 2019 20:47
@xclaesse xclaesse changed the title WIP: gtkdoc: Add 'check' kwarg gtkdoc: Add 'check' kwarg Jul 3, 2019
@nirbheek
Copy link
Member

nirbheek commented Jul 9, 2019

Does this PR contain the alias_target() commit on purpose?

@xclaesse
Copy link
Member Author

xclaesse commented Jul 9, 2019

Does this PR contain the alias_target() commit on purpose?

Yes, I'm depending on it, but PR #5606 can be merged first.

@xclaesse
Copy link
Member Author

alias_target() PR has been merged, so this PR is ready to be reviewed now.

@xclaesse xclaesse force-pushed the gtkdoc-check branch 3 times, most recently from 8726b14 to f6e1dc0 Compare July 11, 2019 20:21
This runs gtkdoc-check in meson tests.

Also reorganize the gtkdoc test because we cannot reliably build
multiple doc into the same directory. Not all files generated by gtk-doc
are prefixed with the target name.
@dcbaker
Copy link
Member

dcbaker commented Jul 16, 2019

Probably should have a release snippet as well?

@xclaesse
Copy link
Member Author

Probably should have a release snippet as well?

Good point, done.

@jpakkane
Copy link
Member

LGTM, I'll merge this once CI gives the green light.

@jpakkane jpakkane merged commit f5da881 into mesonbuild:master Jul 16, 2019
@xclaesse xclaesse deleted the gtkdoc-check branch July 4, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants