Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC: Don't warn when projects add /Wall flag #7969

Closed
wants to merge 1 commit into from

Conversation

drobilla
Copy link
Contributor

See commit message for details.

@jpakkane
Copy link
Member

Looking at MSDN docs, /Wall is a setting that has even more stuff than /W4, meaning it really should be called /W5 for consistency. That would break things, since we specify that warning_level 4 means "everything". sigh Why does everything have to be needlessly complicated?

Could we add the value everything to warning level instead that would explicity mean absolutely everything on every compiler?

@drobilla
Copy link
Contributor Author

Could we add the value everything to warning level instead that would explicitly mean absolutely everything on every compiler?

I hope so (where "absolutely everything" is a little bit tricky but doable, I think). I'm going to take a stab at that as well, this was just some low-hanging fruit. That will be a bit of work, though, current meson warning levels are nowhere near everything for any compiler.

The MSVC /Wall is not like GCC -Wall, it is more like clang -Weverything.  So
Meson was suggesting to use a warning level when there is no warning level that
enables this.
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #7969 (1b86381) into master (b40e4de) will decrease coverage by 1.31%.
The diff coverage is n/a.

❗ Current head 1b86381 differs from pull request most recent head 10b0fe6. Consider uploading reports for the commit 10b0fe6 to get more accurate results

@@            Coverage Diff             @@
##           master    #7969      +/-   ##
==========================================
- Coverage   68.59%   67.28%   -1.32%     
==========================================
  Files         412      207     -205     
  Lines       87867    44928   -42939     
  Branches    20728     9280   -11448     
==========================================
- Hits        60271    30228   -30043     
+ Misses      23088    12419   -10669     
+ Partials     4508     2281    -2227     
Impacted Files Coverage Δ
modules/cuda.py 0.00% <0.00%> (-72.64%) ⬇️
templates/cudatemplates.py 37.50% <0.00%> (-62.50%) ⬇️
compilers/cuda.py 19.63% <0.00%> (-45.40%) ⬇️
dependencies/cuda.py 20.19% <0.00%> (-42.79%) ⬇️
compilers/mixins/clang.py 52.87% <0.00%> (-13.80%) ⬇️
scripts/coverage.py 56.43% <0.00%> (-7.93%) ⬇️
compilers/detect.py 42.97% <0.00%> (-3.63%) ⬇️
linkers/linkers.py 56.35% <0.00%> (-1.25%) ⬇️
environment.py 80.12% <0.00%> (-1.08%) ⬇️
dependencies/misc.py 44.55% <0.00%> (-0.75%) ⬇️
... and 209 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@drobilla
Copy link
Contributor Author

Supplanted by #10554

I guess I'll leave this open until the issue is resolved on master one way or another.

@drobilla drobilla closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants