New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgconfig: Fix linking to a custom target #7996
pkgconfig: Fix linking to a custom target #7996
Conversation
This fix meson crash seen in GStreamer: https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/133#note_696355. CC @nirbheek |
Does not seem to work here: https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/133#note_706950 |
The test failure is hard to pick up from the test output but fairly straightforward when run locally:
|
f6aa1e4
to
69a1933
Compare
Codecov Report
@@ Coverage Diff @@
## master #7996 +/- ##
==========================================
+ Coverage 67.12% 67.15% +0.02%
==========================================
Files 404 404
Lines 85763 85761 -2
Branches 18917 18915 -2
==========================================
+ Hits 57568 57591 +23
+ Misses 23665 23642 -23
+ Partials 4530 4528 -2
Continue to review full report at Codecov.
|
Rebased and hopefully fixed the CI. Targetting 0.60.3 because it's a bugfix. |
The Windows failure seems unrelated, happens on master too. |
69a1933
to
bfbe785
Compare
When generating pkgconfig file for a library that links to an uninstalled static library built by custom_target() Meson was crashing when trying to access some attributes that does not exist on that class. Also fix is_internal() implementation, it only really make sense on a CustomTargetIndex or if CustomTarget has only a single output.
bfbe785
to
eb8d9f0
Compare
LGTM, rebased to see if fixes from master fix the CI. |
When generating pkgconfig file for a library that links to an
uninstalled static library built by custom_target() Meson was crashing
when trying to access some attributes that does not exist on that class.
Also fix is_internal() implementation, it only really make sense on a
CustomTargetIndex or if CustomTarget has only a single output.