Fix run_targets running scripts from different subdirs. #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclaesse
reviewed
Mar 12, 2021
| @@ -4008,6 +4008,8 @@ def func_run_target(self, node, args, kwargs): | |||
| if isinstance(i, dependencies.ExternalProgram) and not i.found(): | |||
| raise InterpreterException(f'Tried to use non-existing executable {i.name!r}') | |||
| cleaned_args.append(i) | |||
| if isinstance(cleaned_args[0], str): | |||
| cleaned_args[0] = self.func_find_program(node, cleaned_args[0], {}) | |||
There was a problem hiding this comment.
Should do that in custom_target() and generator() too for consistency. And probably if it's a File too. OTOH that would be new features, so for 0.57.2 this is probably enough.
There was a problem hiding this comment.
While at it, add_*_script() does some custom lookup in _find_source_script() instead of using find_program() that is subtly not the same thing. IMHO we should remove that code to use fin_program().
And run_command_impl() also does yet another subtly different thing.
There was a problem hiding this comment.
I'll file a separate MR for those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.