Add feed arg to custom_target() #8923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8923 +/- ##
=======================================
Coverage 66.32% 66.33%
=======================================
Files 372 372
Lines 84009 84043 +34
Branches 17515 17525 +10
=======================================
+ Hits 55723 55748 +25
- Misses 23376 23381 +5
- Partials 4910 4914 +4
Continue to review full report at Codecov.
|
emersion
force-pushed
the
custom-target-feed
branch
from
248072a
to
480624d
Compare
jon-turney
suggested changes
Jun 23, 2021
| @@ -383,6 +383,10 @@ following. | |||
| `{'NAME1': 'value1', 'NAME2': 'value2'}` or `['NAME1=value1', 'NAME2=value2']`, | |||
| or an [`environment()` object](#environment-object) which allows more | |||
| sophisticated environment juggling. | |||
| - `feed` *(since 0.59.0)*: there are some compilers that can't be told to read | |||
There was a problem hiding this comment.
Perhaps want to write 'programs' rather than 'compilers'?
There was a problem hiding this comment.
Right. The capture description mentions "compilers", so I just went with that for consistency. Can change if "programs" is better.
|
|
||
| # Note that this will not add a dependency to the compiler executable. | ||
| # Code will not be rebuilt if it changes. | ||
| comp = '@0@/@1@'.format(meson.current_source_dir(), 'my_compiler.py') |
There was a problem hiding this comment.
Um... why are we doing this?
There was a problem hiding this comment.
This is copy-pasta from 109 custom target capture.
There was a problem hiding this comment.
Yeah, that seems to be that way since it was added in 70d94a5. I have no idea why :)
|
This requires a release note snippet. |
emersion
force-pushed
the
custom-target-feed
branch
from
480624d
to
a835e7b
Compare
|
Done. |
|
Thanks for the review! |
emersion
added a commit
to emersion/sway
that referenced
this pull request
Jul 5, 2021
Since [1], Meson allows feeding the input file as stdin and capturing stout to the output file. We don't need the sh hack anymore. [1]: mesonbuild/meson#8923
emersion
added a commit
to emersion/sway
that referenced
this pull request
Jul 26, 2021
Since [1], Meson allows feeding the input file as stdin and capturing stout to the output file. We don't need the sh hack anymore. [1]: mesonbuild/meson#8923
emersion
added a commit
to emersion/sway
that referenced
this pull request
Sep 15, 2021
Since [1], Meson allows feeding the input file as stdin and capturing stout to the output file. We don't need the sh hack anymore. [1]: mesonbuild/meson#8923
emersion
added a commit
to swaywm/sway
that referenced
this pull request
Sep 15, 2021
Since [1], Meson allows feeding the input file as stdin and capturing stout to the output file. We don't need the sh hack anymore. [1]: mesonbuild/meson#8923
RagnarGrootKoerkamp
pushed a commit
to RagnarGrootKoerkamp/sway
that referenced
this pull request
Mar 29, 2022
Since [1], Meson allows feeding the input file as stdin and capturing stout to the output file. We don't need the sh hack anymore. [1]: mesonbuild/meson#8923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of a tool not accepting an input file param is scdoc.