Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome: Add generate_vapi function #895

Merged
merged 1 commit into from
Nov 2, 2016
Merged

gnome: Add generate_vapi function #895

merged 1 commit into from
Nov 2, 2016

Conversation

TingPing
Copy link
Member

@TingPing TingPing commented Oct 11, 2016 •
edited

The test is failing but in gnome-builder everything seems to be generating and installing correctly so I'm not sure what can be done to get it properly be a dependency.

@nirbheek
Copy link
Member

What about vapis that are generated when you build a library? Right now we build those and have no way to install those.

@TingPing
Copy link
Member Author

That is what this is, I'm not sure what you mean.

@nirbheek
Copy link
Member

Nevermind, I was talking about #891. Thought maybe you were also planning on using this to fix that in build files.

grindhold
grindhold reviewed Oct 12, 2016
View reviewed changes
mesonbuild/modules/gnome.py
@@ -643,6 +643,117 @@ def genmarshal(self, state, args, kwargs):
return [body, header]


def _generate_deps(self, state, library, packages, indir):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps generator. love this 👍

@TingPing TingPing force-pushed the wip/tingping/gnome-vapi branch 2 times, most recently from 2b89a9f to 806b052 Compare October 12, 2016 17:36
@TingPing
Copy link
Member Author

Just to mention it in #mesonbuild @nirbheek discussed he would make a few improvements to declare_dependency() that would benefit this function allowing us to simply return a dependency and pass that to Vala directly. So this PR will need to wait on that.

@nirbheek nirbheek mentioned this pull request Oct 15, 2016
Merged
@TingPing TingPing force-pushed the wip/tingping/gnome-vapi branch 2 times, most recently from e8b0a2f to d363063 Compare October 20, 2016 23:51
@TingPing
Copy link
Member Author

TingPing commented Oct 21, 2016 •
edited

Just to note this is still a work in progress, it passes that simple test case but is not robust enough for usage in builder.

This is ready to review/merge.

@TingPing
gnome: Add generate_vapi() function
bae7d7b 
This allows C projects to generate vapi bindings from
gir files and returns a dependency that can be used by
Vala.
@nirbheek nirbheek mentioned this pull request Oct 23, 2016
Closed
@TingPing TingPing mentioned this pull request Oct 26, 2016
Closed
@jpakkane
Copy link
Member

The core LGTM but maybe someone with proper Vala experience might say if the UI and behaviour are good.

@TingPing TingPing added this to the 0.36.0 milestone Nov 1, 2016
@jpakkane jpakkane merged commit 36a0d16 into master Nov 2, 2016
@jpakkane jpakkane deleted the wip/tingping/gnome-vapi branch November 2, 2016 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grindhold grindhold grindhold left review comments

Assignees
No one assigned
Labels
enhancement gnome
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TingPing @nirbheek @jpakkane @grindhold