Fix some gnome module bugs spotted by mypy #9369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theere is no 'output' key in the kwargs, so if this was it it would result in an exception. Mypy spotted this in a branch I'm working on full typing for gnome, but since that seems unlikely to be done before the 0.60 branchpoint I'd like to get this in sooner
It's impossible to get a Holder here, we'd get the unholdered build types. Mypy points this out for us.
Codecov Report
@@ Coverage Diff @@
## master #9369 +/- ##
==========================================
- Coverage 67.04% 67.03% -0.01%
==========================================
Files 394 394
Lines 85274 85280 +6
Branches 17423 17425 +2
==========================================
- Hits 57171 57169 -2
- Misses 23421 23427 +6
- Partials 4682 4684 +2
Continue to review full report at Codecov.
|
install_dir needs to be set to something, because CustomTarget expects that. genmarshal still relies on CustomTarget setting it internally itself. Fixes mesonbuild#9350
dcbaker
force-pushed
the
submit/gnome-bug-fixes
branch
from
eda7371
to
464d3d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a larger branch fully type annotating and using the various `typed_*' decorators, but that's probably not going to be ready before 0.60 is released, and these are real bugs that should be fixed asap.