Run muon format from root of workspace. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows a meaningful relative config file path.
tristan957
reviewed
Nov 21, 2023
| @@ -42,7 +42,7 @@ export async function lint(muon: Tool, root: string, document: vscode.TextDocume | |||
| return diagnostics; | |||
| } | |||
|
|
|||
| export async function format(muon: Tool, document: vscode.TextDocument): Promise<vscode.TextEdit[]> { | |||
| export async function format(muon: Tool, root: string, document: vscode.TextDocument): Promise<vscode.TextEdit[]> { | |||
There was a problem hiding this comment.
Wanna call this argument sourceRoot?
There was a problem hiding this comment.
Only if lint() is changed accordingly...
tristan957
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any reason not to do this? Allows a workspace root relative muon config file path.
Thanks