Look up relative paths to the language server in PATH first

[paveloom]

In the case the custom path to the language server is relative, look it up in PATH first. Useful if the name of the language server is swift-mesonlsp instead of Swift-MesonLSP.

[tristan957]

I guess I am trying to understand a little bit more. Could provide some more context? :)

[paveloom]

Currently, if one sets a custom language server path in the extension options, and they use a binary name (e.g., swift-mesonlsp), this will not work, as the path will be resolved as file:///swift-mesonlsp:

[Error - 7:18:36 PM] Meson Language Server (Swift-MesonLSP) client: couldn't create connection to server.
Launching server using command /swift-mesonlsp failed. Error: spawn /swift-mesonlsp ENOENT

This is handled here:

vscode-meson/src/lsp/index.ts

Lines 151 to 152 in 40d5952

	if (config["languageServerPath"] !== null && config["languageServerPath"] != "")
	return vscode.Uri.from({ scheme: "file", path: config["languageServerPath"] });

That's because vscode.Uri.from expects already resolved paths.

Now, if one doesn't use a custom server path, then the extension will eventually look up PATH for the binary:

vscode-meson/src/lsp/index.ts

Lines 157 to 158 in 40d5952

	const binary = which.sync(server!, { nothrow: true });
	if (binary !== null) return vscode.Uri.from({ scheme: "file", path: binary });

I copied this logic to solve the above scenario.

[JCWasmx86]

Useful if the name of the language server is swift-mesonlsp instead of Swift-MesonLSP.

Why would that ever be the case?

[paveloom]

Well, I just have it like that in Nixpkgs. Might change it, though, so as to align with your packages, @JCWasmx86.

[tristan957]

I see. Thanks for the context. Looks like this is good to merge. What do you think @JCWasmx86?

[JCWasmx86]

LGTM