Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch2: Update to 3.3.2 #1016

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

mikecrowe
Copy link
Contributor

No description provided.

@jpakkane
Copy link
Member

You need to add a new entry to releases.json.

@mikecrowe
Copy link
Contributor Author

You need to add a new entry to releases.json.

Whoops. Thanks. Hopefully that's done now.

The:
catch2| WARNING: Project targets '>=0.50.0' but uses feature introduced in '0.54.1': cmakedefine without exactly two tokens.
sanity check failure confuses me since there were no cmakedefine changes between Catch2 v3.2.0 and v3.3.2.

@neheb
Copy link
Collaborator

neheb commented May 11, 2023

that's an upstream meson change to now warn about a bug fixed in 0.54.1

v1993 added a commit to v1993/Catch2 that referenced this pull request May 14, 2023
horenmar pushed a commit to catchorg/Catch2 that referenced this pull request May 15, 2023
@v1993
Copy link
Contributor

v1993 commented May 15, 2023

Warning fixed upstream, next release should be good.

@neheb neheb merged commit ff87605 into mesonbuild:master May 16, 2023
0 of 7 checks passed
@mikecrowe mikecrowe deleted the mac/catch2-3.3.2 branch May 24, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants